Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] fieldservice_activity #1211

Merged

Conversation

dreispt
Copy link
Member

@dreispt dreispt commented Sep 14, 2024

Supersedes #1183

osi-scampbell and others added 30 commits September 14, 2024 19:08
[IMP] Typo

[IMP] Form/Template Change

[IMP] Show/Hide Buttons

[IMP] PyLint

[IMP] Remove Commented Code

[IMP] Lint
Currently translated at 96.3% (26 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/es_CL/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/es_CL/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/pt_BR/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/es_AR/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/pt_PT/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-13.0/field-service-13.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-13-0/field-service-13-0-fieldservice_activity/es_AR/
Currently translated at 100.0% (28 of 28 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_activity/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-15.0/field-service-15.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_activity/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_activity/it/
Ivorra78 and others added 6 commits September 14, 2024 19:08
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_activity/es/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_activity/pt_BR/
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_activity/pt_BR/
@dreispt
Copy link
Member Author

dreispt commented Sep 14, 2024

@DorianMAG

@dreispt
Copy link
Member Author

dreispt commented Sep 14, 2024

/ocabot migrate fieldservice_activity

@OCA-git-bot
Copy link
Contributor

Hi @dreispt. Your command failed:

Invalid command: migrate.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

Copy link

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the supersedes.
Code review.
LGTM

@dreispt
Copy link
Member Author

dreispt commented Sep 16, 2024

/ocabot migration fieldservice_activity

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Sep 16, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#1132) has not been updated to reference the current pull request because a previous pull request (#1183) is not closed.
Perhaps you should check that there is no duplicate work.
CC @Deriman-Alonso

@max3903
Copy link
Member

max3903 commented Sep 19, 2024

/ocabot migration fieldservice_activity

@max3903 max3903 closed this Sep 19, 2024
@max3903 max3903 reopened this Sep 19, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 19, 2024
46 tasks
@max3903
Copy link
Member

max3903 commented Sep 19, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1211-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 585c5a1 into OCA:17.0 Sep 19, 2024
10 of 11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bb8400c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.